[python] Verify pa.{Chunked,Integer}Array
args to SparseNDArray.read
#2234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context
#1791
Changes
Add a test case to
test_sparse_nd_array_table_slicing
, verifying thatpa.ChunkedArray
(of integers) andpa.IntegerArray
work asSparseNDCoord
s.Notes for Reviewer
Ideally we'd have a repro where:
pa.ChunkedArray
passed toSparseNDArray.read
(before any changes toSparseNDCoord
in somacore; see Addpa.ChunkedArray
toSparseNDCoord
type SOMA#187).pa.ChunkedArray
is added toSparseNDCoord
.The existing test I've modified here apparently isn't subjected to such runtime type-checking. A more explicit version in 0d93315 also doesn't exhibit a type-check failure. I'll keep looking into how to accomplish that.