-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Factor io/ingest.py
, create io/{_common,outgest}.py
#2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryan-williams looks good! Maybe rebase and re-run lint locally & re-push since #2274 is recently merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryan-williams looks good! Maybe rebase and re-run lint locally & re-push since #2274 is recently merged
47d3301
to
24f1861
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
===========================================
+ Coverage 78.56% 90.84% +12.27%
===========================================
Files 137 36 -101
Lines 10684 3855 -6829
Branches 215 0 -215
===========================================
- Hits 8394 3502 -4892
+ Misses 2192 353 -1839
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
io/ingest.py
, create io/{_common,outgest}.py
io/ingest.py
, create io/{_common,outgest}.py
Issue and/or context: #2121
Changes:
to_{h5ad,anndata}
out toio/outgest.py
io/_common.py
Notes for Reviewer: