Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Factor io/ingest.py, create io/{_common,outgest}.py #2246

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ryan-williams
Copy link
Member

Issue and/or context: #2121

Changes:

  • Move to_{h5ad,anndata} out to io/outgest.py
  • Move constants used in both ingest and outgest to io/_common.py

Notes for Reviewer:

@ryan-williams ryan-williams marked this pull request as ready for review March 11, 2024 15:43
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-williams looks good! Maybe rebase and re-run lint locally & re-push since #2274 is recently merged

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-williams looks good! Maybe rebase and re-run lint locally & re-push since #2274 is recently merged

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #2246 (24f1861) into main (874ccb2) will increase coverage by 12.27%.
The diff coverage is 86.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2246       +/-   ##
===========================================
+ Coverage   78.56%   90.84%   +12.27%     
===========================================
  Files         137       36      -101     
  Lines       10684     3855     -6829     
  Branches      215        0      -215     
===========================================
- Hits         8394     3502     -4892     
+ Misses       2192      353     -1839     
+ Partials       98        0       -98     
Flag Coverage Δ
libtiledbsoma ?
python 90.84% <86.76%> (+0.66%) ⬆️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.84% <86.76%> (+0.66%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams merged commit 13d7a2b into main Mar 12, 2024
19 checks passed
@ryan-williams ryan-williams deleted the rw/factor-io branch March 12, 2024 15:12
johnkerl pushed a commit that referenced this pull request Mar 13, 2024
Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
@johnkerl johnkerl changed the title Factor io/ingest.py, create io/{_common,outgest}.py [python] Factor io/ingest.py, create io/{_common,outgest}.py Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants