Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Let ingest accept additional_metadata: dict[str, Metadatum] #2258

Merged
merged 5 commits into from
Mar 21, 2024
Merged

[python] Let ingest accept additional_metadata: dict[str, Metadatum] #2258

merged 5 commits into from
Mar 21, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Mar 13, 2024 •
edited
Loading

Issue and/or context: #2252

TODO:

  • Add test
  • Audit code paths where metadata-writing can be bypassed (e.g.: skip_existing_nonempty_domain branches)
  • ingestor.py tests

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Merging #2258 (02fc32d) into main (6ef6919) will increase coverage by 9.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
+ Coverage   81.28%   90.31%   +9.02%     
==========================================
  Files          88       37      -51     
  Lines        6402     3892    -2510     
  Branches      215        0     -215     
==========================================
- Hits         5204     3515    -1689     
+ Misses       1100      377     -723     
+ Partials       98        0      -98
Flag Coverage Δ
libtiledbsoma ?
python 90.31% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.31% <100.00%> (+0.17%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review March 13, 2024 21:17
@ryan-williams ryan-williams requested a review from johnkerl March 13, 2024 21:17
ryan-williams
ryan-williams commented Mar 15, 2024
View reviewed changes
apis/python/src/tiledbsoma/io/ingest.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/ingest.py Show resolved Hide resolved
apis/python/src/tiledbsoma/io/ingest.py Outdated Show resolved Hide resolved
@johnkerl johnkerl changed the title WIP: ingest accepts additional_metadata: dict[str, str] WIP: ingest accepts additional_metadata: dict[str, Scalar] Mar 15, 2024
@johnkerl johnkerl changed the title WIP: ingest accepts additional_metadata: dict[str, Scalar] [python] Let ingest accept additional_metadata: dict[str, Scalar] Mar 18, 2024
@ryan-williams ryan-williams changed the title [python] Let ingest accept additional_metadata: dict[str, Scalar] [python] Let ingest accept additional_metadata: dict[str, Metadatum] Mar 20, 2024
@ryan-williams ryan-williams mentioned this pull request Mar 21, 2024
Closed
@ryan-williams
Copy link
Member Author

ryan-williams#1 (comment): example test including a tiledb:// URL and new additional_metadata passed.

Believe this is g2g.

@ryan-williams ryan-williams requested a review from johnkerl March 21, 2024 15:44
johnkerl
johnkerl approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryan-williams ryan-williams merged commit 1cea3f6 into main Mar 21, 2024
20 checks passed
@ryan-williams ryan-williams deleted the rw/im branch March 21, 2024 17:16
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@ryan-williams @github-actions
[python] Let ingest accept additional_metadata: dict[str, Metadatum] (
10586e4 
#2258)

* add Metadatum/METADATA_TYPES

* IngextCtx TypedDict

* refine `_create_or_open_collection` type hint

* ingest.py: `add_metadata` helper

* `TileDBObject.verify_open_for_writing()` helper
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Merged
johnkerl pushed a commit that referenced this pull request Mar 21, 2024
@github-actions @ryan-williams
[python] Let ingest accept additional_metadata: dict[str, Metadatum] (
4fb49f4 
#2258) (#2296)

* add Metadatum/METADATA_TYPES

* IngextCtx TypedDict

* refine `_create_or_open_collection` type hint

* ingest.py: `add_metadata` helper

* `TileDBObject.verify_open_for_writing()` helper

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
@johnkerl johnkerl mentioned this pull request Apr 2, 2024
Closed
@ryan-williams ryan-williams mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

Assignees
No one assigned
Labels
backport release-1.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-williams @johnkerl