Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove deprecated Python 3.7 AST types #2271

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Mar 14, 2024

Issue and/or context: #2185

Changes:

  • Remove types from the Python ast package that were deprecated in Python 3.8.

Notes for Reviewer:

@jp-dark jp-dark requested a review from nguyenv March 14, 2024 15:18
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #2271 (ab81f95) into main (382b77c) will increase coverage by 12.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2271       +/-   ##
===========================================
+ Coverage   78.84%   90.99%   +12.14%     
===========================================
  Files         139       36      -103     
  Lines       10736     3843     -6893     
  Branches      215        0      -215     
===========================================
- Hits         8465     3497     -4968     
+ Misses       2173      346     -1827     
+ Partials       98        0       -98     
Flag Coverage Δ
libtiledbsoma ?
python 90.99% <100.00%> (+0.15%) ⬆️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.99% <100.00%> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jp-dark jp-dark merged commit 0fcce69 into main Mar 14, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/post-3.7-type-cleanup branch March 14, 2024 16:14
johnkerl pushed a commit that referenced this pull request Mar 14, 2024
Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
@johnkerl johnkerl changed the title Remove deprecated Python 3.7 ast types [python] Remove deprecated Python 3.7 AST types Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants