-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Implement IntIndexer
as class that wraps around clib.IntIndexer
#2310
Conversation
e91d3d6
to
f70fe92
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
==========================================
- Coverage 78.88% 78.75% -0.14%
==========================================
Files 140 140
Lines 10748 10753 +5
Branches 213 215 +2
==========================================
- Hits 8479 8468 -11
- Misses 2171 2186 +15
- Partials 98 99 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Looks overall good to me. Just some minor comments.
[sc-43678] |
This pull request has been linked to Shortcut Story #43678: [python] Implement IntIndexer as class that wraps around clib.IntIndexer #2187. |
Implement suggestions from @nguyenv
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.8 release-1.8
# Navigate to the new working tree
cd .worktrees/backport-release-1.8
# Create a new branch
git switch --create backport-2310-to-release-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 bc1cd79abadfaba9f8a3d7e81028187857dd9ed8
# Push it to GitHub
git push --set-upstream origin backport-2310-to-release-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.8 Then, create a pull request where the |
Issue and/or context: #2187
Changes:
tiledbsoma_build_index
function with a newIntIndex
class that wrapsclib.IntIndexer
.clib.IntIndexer
class to the python layer usingisinstance
.Notes for Reviewer:
Required a bump in somacore to relax the requirements for an
IndexLike
class.