-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Add tests for enum value filters in SOMAExperimentAxisQuery
#2316
Conversation
Add a tests for doing value filters on enums in `SOMAExperimentAxisQuery`; test for levels both present and missing
Skip missing level tests for core < 2.21
This pull request has been linked to Shortcut Story #43700: [r] Validate experiment query for value not in enumeration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 78.75% 74.69% -4.07%
==========================================
Files 140 52 -88
Lines 10756 4347 -6409
Branches 215 0 -215
==========================================
- Hits 8471 3247 -5224
+ Misses 2187 1100 -1087
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Thanks @mojaveazure !!
Should we have some for |
@eddelbuettel I'm happy with these as the experiment axis-query goes necessarily through dataframe |
@eddelbuettel I don't think |
…2316) * [r] Add tests for enum value filters in `SOMAExperimentAxisQuery` Add a tests for doing value filters on enums in `SOMAExperimentAxisQuery`; test for levels both present and missing * Add tests for handling missing levels Skip missing level tests for core < 2.21
I used this to test (and posted it, here I omitted the preceding uri <- tempfile()
pp <- data.frame(soma_joinid=as.integer64(1:344), penguins)
fromDataFrame(pp, uri, col_index=1)
set_log_level("debug")
#sdf <- SOMADataFrameOpen(uri)$read(value_filter="species == \"Adelie\"")$concat()
sdf <- SOMADataFrameOpen(uri)$read(value_filter="species == \"Frodo\"")$concat()
print(sdf)
cat("And done\n") |
…2316) (#2317) * [r] Add tests for enum value filters in `SOMAExperimentAxisQuery` Add a tests for doing value filters on enums in `SOMAExperimentAxisQuery`; test for levels both present and missing * Add tests for handling missing levels Skip missing level tests for core < 2.21 Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
Add a tests for doing value filters on enums in
SOMAExperimentAxisQuery
; test for levels both present and missing. Skip missing level tests for core < 2.21addresses #1988
[sc-43700]