Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.9] [c++, r] Update and refactor nanoarrow #2363

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Apr 3, 2024

Backport aa0adcb from #2188

* Update nanoarrow vendored files to nanoarrow 0.4.0

* Low-level wiring of nanoarrow at sr_* level

* More lower-level wiring of nanoarrow

* WIP snapshot with nanoarrow wired into libtiledbsoma

* Ensure nullable is set correctly in either case

* Context wrapped in a special purpose struct should not finalize

* Simpler and faster r-ci.yaml

* Use nanoarrow 0.4.0 consistently

* Refined arrow_adapter

* Set increased timeout for download.file to survive GH flakyness

* Turn trace back of, do not include carrow in cli

* Do not include carrow.h in reindexer.cc

* WIP changes expanding type map, suppressing schema release

* [c++] Fix segfault issues

* Add additional necessary strdup

* No longer to protect one statement

* Support TILEDB_DATETIME_DAY aka Date as well

* Meh

* Meh with version 14.0.0 and not 14.0.6 because ... sure

* Remove initialization setters covered by nanoarrow use

* Ensure DATETIME columns get Arrow coltype reset

* Add more date and datetime support

* Additional conversion

* Post-rebase change

* Heeding time to the lord of linting is time well spent some say

* Heeding time to the lord of linting is time well spent some say

* Correct another delete to free

* Additional non-nullptr protection

* make format

* Additional test conditioner

* Correcting one buffer size selection

* make format

* Remove carrow.h and reference to it

* Cleanups

* Use nanoarrow.{c,hpp} via tiledbsoma/utils/

* Re-activate -Werror

* Chore

* High-productivity afternoon

* Correct an format string error message

---------

Co-authored-by: Vivian Nguyen <vivian@tiledb.com>
@johnkerl johnkerl merged commit 2594735 into release-1.9 Apr 3, 2024
@johnkerl johnkerl deleted the backport-2188-to-release-1.9 branch April 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants