[c++,r,python] Move nanoarrow to src/external
#2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #44473: [c++] Mnve |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 66.04% 65.36% -0.69%
==========================================
Files 144 144
Lines 13000 12998 -2
Branches 511 509 -2
==========================================
- Hits 8586 8496 -90
- Misses 4314 4414 +100
+ Partials 100 88 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2362
Issue and/or context:
As described in #2362 the initial location of the three vendored
nanoarrowfiles was just a first, placing them intosrc/externalis better (and the upcoming version 0.5.0 ofnanoarrowshould allow it also (more easily) an external cmake project.Changes:
The files have been moved, restored to their pristine release 0.4.0 form (undoing our formatting), and include and config locations have been adjusted.
Notes for Reviewer:
There may be smoother ways to do this, I would be more than happy to accommodate change requests from anybody deeper into CMake and Python than I am.
SC 44473