[c++] Fix bug in nnz
of variant-indexed dataframes
#2990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Pre-existing bug found while working on issue #2407 / [sc-51048].
I ran
sdf.count()
on a variant-indexed dataframe which has dim0 being a string (which the spec allows even though most users don't take advantage of this). I got the errorThere is a repro now built into the unit-test cases on this PR.
Changes:
Only use the code that assumes dim0 is
int64
soma_joinid
when that is in fact the case.Notes for Reviewer: