Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Fix bug in nnz of variant-indexed dataframes #2990

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: Pre-existing bug found while working on issue #2407 / [sc-51048].

I ran sdf.count() on a variant-indexed dataframe which has dim0 being a string (which the spec allows even though most users don't take advantage of this). I got the error

[TileDB::FragmentInfo] Error: Cannot get non-empty domain; Dimension is variable-sized

There is a repro now built into the unit-test cases on this PR.

Changes:

Only use the code that assumes dim0 is int64 soma_joinid when that is in fact the case.

Notes for Reviewer:

@johnkerl
Copy link
Member Author

Leaving in draft while I address a unit-test failure

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (4a13a82) to head (265c9b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          40       40              
  Lines        4096     4096              
==========================================
+ Hits         3672     3678       +6     
+ Misses        424      418       -6     
Flag Coverage Δ
python 89.79% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review September 19, 2024 22:07
@johnkerl johnkerl merged commit 16fcd68 into main Sep 20, 2024
25 checks passed
@johnkerl johnkerl deleted the kerl/variant-nnz-bug branch September 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants