Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Update dataframe unit-test writes in prep for polytype domainish accessors #3017

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 19, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Split-out underneath #3012

Notes for Reviewer:

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (6f723d4) to head (bf78157).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3017       +/-   ##
===========================================
+ Coverage   61.10%   89.79%   +28.69%     
===========================================
  Files          95       40       -55     
  Lines       12382     4096     -8286     
  Branches      781        0      -781     
===========================================
- Hits         7566     3678     -3888     
+ Misses       4625      418     -4207     
+ Partials      191        0      -191     
Flag Coverage Δ
libtiledbsoma ?
python 89.79% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 16a6c10 into main Sep 19, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/polydom5 branch September 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants