[r] Move parse_query_condition_new -> parse_query_condition
#3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/r-qc-apply
branch
2 times, most recently
from
fdcc4a9
to
d36731f
Compare
johnkerl
force-pushed
the
kerl/r-qc-apply
branch
from
d36731f
to
b224f48
Compare
johnkerl
commented
Oct 16, 2024
| @@ -15,33 +15,24 @@ test_that("Arrow Interface from SOMAArrayReader", { | |||
| tb1 <- soma_array_to_arrow_table(soma_array_reader(uri, columns)) | |||
| expect_equal(tb1$num_rows, 2638) | |||
|
|
|||
| arr <- tiledb_array(uri) # need array for schema access to qc parser | |||
There was a problem hiding this comment.
already tested in tests/testthat/test-query-condition.R
mojaveazure
approved these changes
Oct 16, 2024
Comment on lines
+18
to
+19
| # Unlike in pyarrow there is no arrow::large_string | ||
| arrow::field("utf8", arrow::utf8()), |
There was a problem hiding this comment.
There is arrow::large_utf8() in Arrow-R
There was a problem hiding this comment.
Indeed, and I test large_utf8 on this PR -- thank you!
johnkerl
force-pushed
the
kerl/r-qc-apply
branch
from
b224f48
to
562b0f7
Compare
johnkerl
changed the title
parse_query_condition_new -> parse_query_conditionparse_query_condition_new -> parse_query_condition
johnkerl
force-pushed
the
kerl/r-qc-apply
branch
from
562b0f7
to
4b6c4d3
Compare
johnkerl
added a commit
that referenced
this pull request
Oct 16, 2024
johnkerl
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Issue #3051 / [sc-55672]. Stack: #3162, #3163, this.
Changes:
Replaces the existing
parse_query_condition, which uses TileDB-R, with the one currently namedparse_query_condition_newwhich useslibtiledbsoma.Notes for Reviewer:
This or #3163 can be landed in either order.