[python] Update spatial API to match somacore 1.0.23 #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make subcollection always a positional argument (for consistency). - Fix docstrings for `create` methods (no default value for subcollection).
…#3262) * Directly take the `CoordinateSpace` as a creation parameter. * Remove confusing `image_type` property/creation parameter. Use `data_axis_order` instead which uses the axis names the user provided. * Create the first resolution level when creating the `MultiscaleImage`. * Require the `add_new_level` to only add images smaller than the base (level=0) image. * Add a `set` method for adding images that exist outside of SOMA. * Add a property to check the number of channels in the image. * Replace public facing `ImageProperties` class with internal `_LevelProperties` class.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3274 +/- ##
==========================================
- Coverage 83.81% 83.77% -0.04%
==========================================
Files 51 51
Lines 5578 5554 -24
==========================================
- Hits 4675 4653 -22
+ Misses 903 901 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the TileDB-SOMA implementation to support the API changes in somacore 1.0.23.
This is includes:
MultiscaleImagechanges already approved in [python] Update theMultiscaleImageto matchsomacoreAPI changes #3262subcollectionparameters in theSceneclass