Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Add ManagedQuery bindings #3281

Merged
merged 2 commits into from
Nov 4, 2024
Merged

[python] Add ManagedQuery bindings #3281

merged 2 commits into from
Nov 4, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Nov 2, 2024

Issue and/or context:

As part of work for #3053.

Changes:

Adds ManagedQuery bindings to Pybind11 code.

@nguyenv nguyenv requested a review from johnkerl November 4, 2024 18:48
johnkerl
johnkerl approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just a copy from soma_array.cc -- correct?

You'll remove the 'old' bindings from soma_array.cc on a subsequent PR?

Base automatically changed from mq-add-constructor to main November 4, 2024 20:43
@nguyenv
Copy link
Member Author

nguyenv commented Nov 4, 2024

Yes when I replace SOMAArray.write with ManagedQuery, I will remove those from soma_array.cc. That's something planned for the upcoming GOW refactor.

@nguyenv nguyenv merged commit f84486f into main Nov 4, 2024
21 checks passed
@nguyenv nguyenv deleted the add-mq-bindings branch November 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyenv @johnkerl