[python] Geometry DataFrame #3297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en creating schema
…ing an array for read unless explicity specify them
johnkerl
reviewed
Nov 6, 2024
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
nguyenv
reviewed
Nov 7, 2024
Comment on lines
+123
to
+124
| if not isinstance(coordinate_space, CoordinateSpace): | ||
| coordinate_space = CoordinateSpace.from_axis_names(coordinate_space) |
There was a problem hiding this comment.
Is this check robust enough? Typeguard will preemptively throw a type error for anything that isn't Sequence[str] or CoordinteSpace before it gets here?
| spatial_column_data, schema=pa.schema(spatial_column_schema) | ||
| ) | ||
|
|
||
| print(spatial_column_info) |
There was a problem hiding this comment.
Suggested change
| print(spatial_column_info) |
| # [4] core current domain hi | ||
|
|
||
| spatial_column_schema.append(pa_field) | ||
| if NEW_SHAPE_FEATURE_FLAG_ENABLED: |
There was a problem hiding this comment.
This flag has been removed as of #3301. Will need to rebase with main.
jp-dark
reviewed
Nov 8, 2024
XanthosXanthopoulos
force-pushed
the
xan/hide_internal_dims
branch
from
3e6d9f2
to
87cef7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python implementation of SOMAGeometryDataFrame