Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Vignette for new-shape feature #3302

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 6, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

This is the R counterpart to #3294.

Notes for Reviewer:

There will be Academy material as well, in a separate PR.

@johnkerl johnkerl force-pushed the kerl/new-shape-vignette branch 3 times, most recently from 6aff832 to e7e0133 Compare November 7, 2024 00:19
@johnkerl johnkerl force-pushed the kerl/new-shape-vignette branch 2 times, most recently from 5d38375 to 91ec81d Compare November 7, 2024 17:00
@johnkerl johnkerl force-pushed the kerl/new-shape-vignette branch 2 times, most recently from 3adfcf6 to d4ffe39 Compare November 14, 2024 19:36
@johnkerl johnkerl changed the title [r] Vignette for new-shape feature [WIP] [r] Vignette for new-shape feature Nov 15, 2024
@johnkerl johnkerl marked this pull request as ready for review November 15, 2024 18:56
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (d0cbd2d) to head (aa39bfc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
+ Coverage   85.09%   85.27%   +0.17%     
==========================================
  Files          53       53              
  Lines        5577     5574       -3     
==========================================
+ Hits         4746     4753       +7     
+ Misses        831      821      -10     
Flag Coverage Δ
python 85.27% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.27% <100.00%> (+0.17%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant