Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix some warnings at anndata==0.11 #3306

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 7, 2024

Follow-on to #3305

Unfortunately, I still see these which appear to be outside of our control:

>>> import scanpy
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_csv from `anndata` is deprecated. Import anndata.io.read_csv instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_excel from `anndata` is deprecated. Import anndata.io.read_excel instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_hdf from `anndata` is deprecated. Import anndata.io.read_hdf instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_loom from `anndata` is deprecated. Import anndata.io.read_loom instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_mtx from `anndata` is deprecated. Import anndata.io.read_mtx instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_text from `anndata` is deprecated. Import anndata.io.read_text instead.
  warnings.warn(msg, FutureWarning)
/Users/kerl/.pyenv/versions/3.11.9/lib/python3.11/site-packages/anndata/utils.py:429: FutureWarning: Importing read_umi_tools from `anndata` is deprecated. Import anndata.io.read_umi_tools instead.

@johnkerl johnkerl requested review from ivirshup and removed request for ivirshup November 7, 2024 19:50
@johnkerl johnkerl force-pushed the kerl/anndata-0.11-warnings branch 2 times, most recently from 516ab95 to 934c469 Compare November 7, 2024 19:55
@johnkerl johnkerl changed the title [python] Fix warnings at anndata==0.11 [python] Fix some warnings at anndata==0.11 Nov 7, 2024
@johnkerl johnkerl marked this pull request as ready for review November 7, 2024 20:12
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (33b104c) to head (ee4b946).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
+ Coverage   85.29%   85.43%   +0.13%     
==========================================
  Files          52       52              
  Lines        5517     5505      -12     
==========================================
- Hits         4706     4703       -3     
+ Misses        811      802       -9     
Flag Coverage Δ
python 85.43% <55.55%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.43% <78.57%> (+0.13%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Collaborator

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could ignore the warning from scanpy at any point you import scanpy, but they will be silenced in upcoming scanpy releases.

@johnkerl johnkerl merged commit 5c31eb6 into main Nov 8, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/anndata-0.11-warnings branch November 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants