Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] TileDBConfig type alias, misc. type annotations #3317

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Nov 8, 2024

  • We use Dict[str, Union[str, float]] throughout the codebase to mean "TileDB config"; this factors+names that.
  • Made some types more explicit+precise in test_experiment_query.py.
  • Reference some types directly (instead of as strings)

@ryan-williams ryan-williams changed the title [python] TileDBConfig type alias, test fixture return types [python] TileDBConfig type alias, misc type annotations Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (a71c3b7) to head (8afee2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
+ Coverage   85.32%   85.51%   +0.18%     
==========================================
  Files          52       52              
  Lines        5514     5517       +3     
==========================================
+ Hits         4705     4718      +13     
+ Misses        809      799      -10     
Flag Coverage Δ
python 85.51% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.51% <100.00%> (+0.18%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python] TileDBConfig type alias, misc type annotations [python] TileDBConfig type alias, misc. type annotations Nov 8, 2024
@ryan-williams ryan-williams marked this pull request as ready for review November 8, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant