Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix and test SpatialData transformation exporter #3330

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 18, 2024

Fixes:

  • Fix changes from SOMA coordinate axis names to SpatialData coordinate dimension names.
  • Invert SOMA scene-to-points transform to correctly store SpatialData point-to-scene transformation.
  • Fix type annotation for GeoPandas GeoDataFrame.

Clean-up:

  • Import spatialdata as sd.
  • Add tests for converting transformations.

@jp-dark jp-dark force-pushed the dark/spatial-data-transformations branch from ba80407 to 4ecda24 Compare November 18, 2024 17:10
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (946d3f7) to head (4ecda24).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
+ Coverage   85.14%   85.38%   +0.23%     
==========================================
  Files          53       53              
  Lines        5568     5568              
==========================================
+ Hits         4741     4754      +13     
+ Misses        827      814      -13     
Flag Coverage Δ
python 85.38% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.38% <100.00%> (+0.23%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@jp-dark jp-dark merged commit d69b270 into main Nov 19, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/spatial-data-transformations branch November 19, 2024 14:38
@johnkerl johnkerl changed the title Fix and test SpatialData transformation exporter [python] Fix and test SpatialData transformation exporter Nov 19, 2024
@jp-dark
Copy link
Collaborator Author

jp-dark commented Nov 20, 2024

Fix to sc-57972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants