Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Removetiledb_ctx references from _soma_tiledb_context.py #3341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Nov 19, 2024

Follow-up from #2752. Issue: #1632.

@ryan-williams ryan-williams changed the title rm tiledb_ctx references from _soma_tiledb_context.py [python] rm tiledb_ctx references from _soma_tiledb_context.py Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (cde6da1) to head (56946e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3341      +/-   ##
==========================================
+ Coverage   85.71%   85.81%   +0.09%     
==========================================
  Files          57       57              
  Lines        6169     6169              
==========================================
+ Hits         5288     5294       +6     
+ Misses        881      875       -6     
Flag Coverage Δ
python 85.81% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.81% <100.00%> (+0.09%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@ryan-williams ryan-williams marked this pull request as ready for review November 19, 2024 20:16
@johnkerl johnkerl changed the title [python] rm tiledb_ctx references from _soma_tiledb_context.py [python] Removetiledb_ctx references from _soma_tiledb_context.py Nov 19, 2024
@nguyenv
Copy link
Member

nguyenv commented Nov 20, 2024

Your documentation corrections are good for how TileDBSOMAContext currently works, but I am doing some refactoring in #3335 which might nullify these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants