Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add MultiscaleImage level SpatialData exporter #3342

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 19, 2024

Exports a single resolution level of MultiscaleImage to a SpatialData Image2DModel or Image3DModel.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (8840de0) to head (985884e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
+ Coverage   85.66%   85.74%   +0.08%     
==========================================
  Files          57       57              
  Lines        6180     6203      +23     
==========================================
+ Hits         5294     5319      +25     
+ Misses        886      884       -2     
Flag Coverage Δ
python 85.74% <80.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.74% <80.00%> (+0.08%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

Exports a single resolution level of `MultiscaleImage` to a SpatialData
Image2DModel or Image3DModel.
@jp-dark jp-dark force-pushed the dark/spatial-data-single-image/sc-57969 branch from c30f3e6 to 8e0c706 Compare November 19, 2024 22:08
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with nits) -- but I defer to @ivirshup for domain expertise

apis/python/src/tiledbsoma/experimental/outgest.py Outdated Show resolved Hide resolved
@johnkerl johnkerl changed the title Add MultiscaleImage level SpatialData exporter [python] Add MultiscaleImage level SpatialData exporter Nov 19, 2024
@jp-dark
Copy link
Collaborator Author

jp-dark commented Nov 20, 2024

sc-57969

@jp-dark jp-dark merged commit b6af5d7 into main Nov 20, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/spatial-data-single-image/sc-57969 branch November 20, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants