Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add PointCloudDataFrame to SpatialData points model #3357

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 20, 2024

Add a function to export a SOMA PointCloudDataFrame to the SpatialData "points" model.

@jp-dark
Copy link
Collaborator Author

jp-dark commented Nov 20, 2024

sc-57971

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (b6af5d7) to head (e504a5d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3357      +/-   ##
==========================================
+ Coverage   85.65%   85.76%   +0.11%     
==========================================
  Files          57       57              
  Lines        6203     6210       +7     
==========================================
+ Hits         5313     5326      +13     
+ Misses        890      884       -6     
Flag Coverage Δ
python 85.76% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.76% <100.00%> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@jp-dark jp-dark changed the title Add PointCloudDataFrame to SpatialData points model [python] Add PointCloudDataFrame to SpatialData points model Nov 21, 2024
Copy link
Collaborator

@ktsitsi ktsitsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misc

apis/python/tests/test_export_point_cloud_dataframe.py Outdated Show resolved Hide resolved
@jp-dark jp-dark requested a review from nguyenv November 21, 2024 19:41
@jp-dark jp-dark merged commit c46175d into main Nov 21, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/sc-57971 branch November 21, 2024 20:32
@johnkerl johnkerl changed the title [python] Add PointCloudDataFrame to SpatialData points model [python] Add PointCloudDataFrame to SpatialData points model Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants