[r] Remove calls to tiledb::tiledb_version()
#3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace calls to `tiledb::tiledb_version()` with new helper function `get_tiledb_version()`; `get_tiledb_version()` wraps `tiledb_embedded_version()`, but adds a parameter `compact` to replicate the `compact = TRUE` mode of `tiledb::tiledb_version()` [SC-62779](https://app.shortcut.com/tiledb-inc/story/62779)
johnkerl
approved these changes
Jan 31, 2025
mojaveazure
merged commit fe3378c
into
paulhoffman/sc-62760/remove-tiledb-r-as-a-dependency-from-tiledbsoma
4 checks passed
mojaveazure
deleted the
paulhoffman/sc-62779/remove-calls-to-tiledb-tiledb-version
branch
mojaveazure
added a commit
that referenced
this pull request
Feb 3, 2025
* [r] Remove calls to `tiledb::tiledb_version()` Replace calls to `tiledb::tiledb_version()` with new helper function `get_tiledb_version()`; `get_tiledb_version()` wraps `tiledb_embedded_version()`, but adds a parameter `compact` to replicate the `compact = TRUE` mode of `tiledb::tiledb_version()` Also add names to `get_tiledb_version(compact = FALSE)` [SC-62779](https://app.shortcut.com/tiledb-inc/story/62779)
mojaveazure
added a commit
that referenced
this pull request
Feb 7, 2025
* [r] Remove calls to `tiledb::tiledb_version()` Replace calls to `tiledb::tiledb_version()` with new helper function `get_tiledb_version()`; `get_tiledb_version()` wraps `tiledb_embedded_version()`, but adds a parameter `compact` to replicate the `compact = TRUE` mode of `tiledb::tiledb_version()` Also add names to `get_tiledb_version(compact = FALSE)` [SC-62779](https://app.shortcut.com/tiledb-inc/story/62779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to
tiledb::tiledb_version()with new helper functionget_tiledb_version();get_tiledb_version()wrapstiledb_embedded_version(), but adds a parametercompactto replicate thecompact = TRUEmode oftiledb::tiledb_version()sc-62779
continues work for #2406
Note: this PR is not going into
main, but into a separate branch to accumulate all of these little PRs before filing the larger one to remove tiledb-r