Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits get made, even if the gem being updated had it's version stay the same #11

Open
sbleon opened this issue Nov 1, 2018 · 5 comments
Assignees

Comments

@sbleon
Copy link
Member

sbleon commented Nov 1, 2018

(1/40) Updating actioncable 5.2.0 -> 5.2.1
ERROR: Bundler tried to update actioncable but is version stayed the same

I end up with a commit message that says "actioncable 5.2.1 (was 5.2.0)", but it actually only updates dependencies of actioncable.

@shanecav84
Copy link
Member

We might be able to do two bunup runs: one with --only-explicit for Bundler 1.17+ to update gems specifically listed in the Gemfile; and a run without the --only-explicit to get everything.

@sbleon
Copy link
Member Author

sbleon commented Nov 7, 2018

Yeah, I like that idea! Hit the top-level dependencies first, then the transitive dependencies that are still behind.

@shanecav84
Copy link
Member

We could bring in another dependency, bundler-stats, which has some nice tools to get a Gemfile's dependency information and can output parseable JSON.

@sbleon
Copy link
Member Author

sbleon commented Nov 7, 2018 via email

@shanecav84
Copy link
Member

Just that it won't support less than Bundler 1.17 and helping people upgrade from really old versions of stuff is a use case for this gem. I'm find doing the double-run for just Bundler 1.17 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants