Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding connection while executing the sql magic. #1

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

nkitsaini
Copy link

Describe your changes

Allow overriding connection while executing the sql magic. This is used in singlestore-labs/singlestoredb-python#47.

Issue number

Checklist before requesting a review

@kesmit13
Copy link

I'm not clear how this will have any effect in our notebook container since we are installing the official Jupysql package there.

@nkitsaini
Copy link
Author

nkitsaini commented Dec 10, 2024

@kesmit13 We will update the notebook image to install this fork instead of installing from pypi. We have done the same for modifications to dash library: Dockerfile changes

@kesmit13 kesmit13 merged commit 4373b96 into master Dec 10, 2024
@kesmit13 kesmit13 deleted the users/asaini/allow-connection-override branch December 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants