Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip banned posts when parsing, because they contain no files #7

Closed
wants to merge 2 commits into from
Closed

Conversation

f8upd8
Copy link

@f8upd8 f8upd8 commented Oct 25, 2022

Allows get_images to work when encountering banned posts without image files.

@da-vinci-bot
Copy link

da-vinci-bot bot commented Oct 25, 2022

Hey?! @MalOMaw We will get back to you soon! OwO


Click here to make your day UmU
abc

@sinkaroid
Copy link
Owner

@MalOMaw could you enable the workflows check in your PR, why the CI is not running? just want to ensure there is no breaking flow with other boorus and we can see the danbooru result

@sinkaroid sinkaroid added the bug Something isn't working label Dec 6, 2022
@sinkaroid
Copy link
Owner

Hey, I have test with your flow, I think is_banned does not affect at all though, idk why it's still throwing the KeyError despite i["file_url"] always there

@f8upd8
Copy link
Author

f8upd8 commented Dec 17, 2022

Hi, I assume you rewritten and deleted the module? If banned danbooru posts don't affect it, I think we can close the PR

@sinkaroid
Copy link
Owner

Yes, I realized the old version was bad behaviour.

  1. intended for async usage but still depends on requests lib Library is not ready for async usage #3
  2. injecting query parameters for block image with -{block}* eg: -furry* is takes more arguments on each booru, and sometime exceed the limit tags

should be fixed now

@sinkaroid sinkaroid closed this Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr:pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants