Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save methods of children Date instance (#437) #480
fix: save methods of children Date instance (#437) #480
Changes from 3 commits
e35e2af
eb7923a
35363ee
d5043c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 27 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 54 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 60 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 332 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 412 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 436 in src/fake-timers-src.js
Codecov / codecov/patch
src/fake-timers-src.js#L435-L436
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to do a little brush up on Proxy objects and its apply to grok the logic, which made me pay so much attention to the details that I failed to see the
toString()
bit. That was until I actually read section 15.9.2:Ooh. Did not remember this. Had to check:
I'd rather extract that into a silly, but aptly named, little method called
currentDateTimeAsString()
and stuff all the details there, though! Makes small minds as my own able to grok the bigger picture faster. Makes for quicker 🆗 on PRs 😅 I know the bit of code was already there, though, so no worries!Check warning on line 449 in src/fake-timers-src.js
Codecov / codecov/patch
src/fake-timers-src.js#L449
Check warning on line 632 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 763 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 774 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 785 in src/fake-timers-src.js
GitHub Actions / lint
Check warning on line 797 in src/fake-timers-src.js
GitHub Actions / lint