Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix #489 (Skypack import) by converting to ESM. Using top-level await is only allowed in Ecmascript modules, so if we were to use
await import(...)
in a CJS module, it would change our public interface, as we would have to somehow expose the fact that we need to await a Promise. So to keep the same interface, an ESM conversion seems necessary.This change should not be handled without forethought ... To be able to do this, we probably need
to convert the main
sinon
package to ESM as well.Here is what happens if I pull in the ESM version of this library into Sinon:
We also need to fix linting issues and I was not successful in figuring out how to override
languageOptions.sourceType
.Pretty sure this is just the start in opening up a can of worms ...