Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #67

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Update dependencies #67

merged 3 commits into from
Apr 11, 2022

Conversation

sarahmish
Copy link
Collaborator

Resolve #66

@sarahmish sarahmish requested review from a team, dyuliu and frances-h and removed request for a team April 3, 2022 05:28
setup.py Outdated Show resolved Hide resolved
@sarahmish sarahmish requested a review from frances-h April 7, 2022 14:05
setup.py Outdated
@@ -59,6 +56,7 @@
'sphinx_rtd_theme>=0.2.4,<0.5',
'docutils>=0.14,<0.18',
'autodocsumm>=0.1.10',
'Jinja2<3.1',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check which Jinja2 version is installed? What about using this range Jinja2>=2,<3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 3.1 breaks sphinx, your suggestion works!

Copy link

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sarahmish sarahmish merged commit ffd5129 into master Apr 11, 2022
@sarahmish sarahmish deleted the dev-dep branch April 11, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Draco dependencies
3 participants