Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem understanding why build is breaking when new interface introduced #113

Closed
vmassol opened this issue Mar 2, 2016 · 3 comments
Closed

Comments

@vmassol
Copy link

vmassol commented Mar 2, 2016

I'm trying to have the build fail when backward compatiblity is broken. However at the moment I have japicmp failing the build when new interfaces are added (I have source breakage on):

+++* NEW INTERFACE: PUBLIC(+) ABSTRACT(+) org.xwiki.component.namespace.NamespaceValidator  (not serializable)
        +++* NEW SUPERCLASS: java.lang.Object
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) void checkAllowed(java.util.Collection, java.lang.String)
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) boolean isAllowed(java.util.Collection, java.lang.String)
        +++  NEW ANNOTATION: org.xwiki.component.annotation.Role

This cannot be a backward incompatibility breakage since this is a new interface so there cannot be old code using it...

I don't understand why japicmp reports it as a source incompatibility.

Any idea?

Thanks!

@siom79
Copy link
Owner

siom79 commented Mar 2, 2016

This looks like a bug. A check that verifies if the interface itself is new seems to be missing.

I will fix it ASAP.

@vmassol
Copy link
Author

vmassol commented Mar 2, 2016

ok great, thanks.

siom79 added a commit that referenced this issue Mar 5, 2016
…compatible, #113 method that overrides in subinterface method from superinterface is no longer detected as source incompatible
@siom79
Copy link
Owner

siom79 commented Mar 5, 2016

Fixed on the develop branch.

In case you want to try it out:

git clone https://github.com/siom79/japicmp.git
cd japicmp
git checkout develop
mvn install

@siom79 siom79 closed this as completed Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants