Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make epoll-multiplexer thread safe #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

attila-lendvai
Copy link
Contributor

Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate
the events array, and thus make HARVEST-EVENTS safe for concurrent calls.

@attila-lendvai
Copy link
Contributor Author

@sionescu, what's the deal with this? shall i rebase it? will you merge it?

i need it in our production systems and it's a headache to keep it in sync with master.

@attila-lendvai
Copy link
Contributor Author

@sionescu any decision on this? do you theoretically agree to this?

i understand if you have no time to deal with it right now. i just want to know what to expect in the future, because we need to maintain a separate repo for this single patch to build our production systems (as opposed to simply getting iolib from quicklisp).

Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate
the events array, and thus make HARVEST-EVENTS safe for concurrent calls.
@attila-lendvai
Copy link
Contributor Author

i had to rebase this, it should merge fine into the current master.

@darabi
Copy link

darabi commented May 22, 2021

Hi @sionescu,

as a hu.dwim.web-server user, I'm also interested in this patch.
Will it be merged some time soon or should it be implemented differently?

Thank you

@attila-lendvai
Copy link
Contributor Author

@sionescu i'm still maintaining this several years later, but it's quite a straightforward patch: it just moves the allocation of the buffer to the thread instead of a shared slot on the object. and i doubt it has serious performance implications.

any reason this is still not merged?

this was needed to fix an actually manifesting bug in our webapps.

sionescu pushed a commit that referenced this pull request Jun 8, 2024
GitHub Pull Request: #28

Make epoll-multiplexer thread safe

Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate
the events array, and thus make HARVEST-EVENTS safe for concurrent calls.


Patch-set: 1
Change-id: I64a679e6b869b3c40cbd7a95b83fc08003933e6c
Subject: Make epoll-multiplexer thread safe
Branch: refs/heads/master
Status: new
Topic: 
Commit: 4b64aec
Tag: autogenerated:gerrit:newPatchSet
Groups: 4b64aec
Private: false
Work-in-progress: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants