Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp of hep packets discarded in loki #544

Closed
tsearle opened this issue Feb 20, 2024 · 0 comments · Fixed by #545
Closed

timestamp of hep packets discarded in loki #544

tsearle opened this issue Feb 20, 2024 · 0 comments · Fixed by #545
Assignees
Labels
enhancement New feature or request

Comments

@tsearle
Copy link
Contributor

tsearle commented Feb 20, 2024

when hep packets arrive to the heplify server out of order to the heplify-server, the server re-writes the timestamps before sending to LOKI, causing them to appear out of order in call flow diagrams

the code doing the timestamp re-writing is located here

I propose adding a flag allow_out_of_order (similar to what vector has) to allow timestamps to be preserved.

// guard against entry out of order errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants