Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go vet errors (#473) #474

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

ncopa
Copy link
Contributor

@ncopa ncopa commented Jun 7, 2021

Fixes go vet errors:

# github.com/sipcapture/heplify-server/rotator
rotator/rotator.go:222:2: unreachable code
# github.com/sipcapture/heplify-server/decoder
decoder/decoder.go:299:35: possible misuse of reflect.SliceHeader

see golang/go#40701

Fixes go vet errors:

    # github.com/sipcapture/heplify-server/rotator
    rotator/rotator.go:222:2: unreachable code
    # github.com/sipcapture/heplify-server/decoder
    decoder/decoder.go:299:35: possible misuse of reflect.SliceHeader

see golang/go#40701
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021

CLA assistant check
All committers have signed the CLA.

@adubovikov
Copy link
Member

Thank you!. Can you please sign CLA ?

@ncopa
Copy link
Contributor Author

ncopa commented Jun 7, 2021

please have a close look at those changes, because

  • I have no clue what this code actually does
  • The rotator thing may return an error where it previously ignored it.
  • I'm mainly doing a qualified guess that the reflect.SliceHeader fix is correct based on what I saw other projects do with the same error - but I don't really understand what happens.

@lmangani
Copy link
Member

lmangani commented Jun 7, 2021

Changes approved, minor version increase required for a new package to be built

@adubovikov adubovikov merged commit 524c02b into sipcapture:master Jun 7, 2021
@ncopa ncopa deleted the fix-go-vet-errors branch June 7, 2021 17:00
@ncopa ncopa mentioned this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants