Merge pull request #534 from sir-gon/develop

Develop
sir-gon · Sep 24, 2024 · 13218a1 · 13218a1
2 parents ef03020 + e455d1a
commit 13218a1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 20 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -159,7 +159,11 @@ const jestConfig = {
   testMatch: ['**/?(*.)+(spec|test).js?(x)'],
 
   // An array of regexp pattern strings that are matched against all test paths, matched tests are skipped
-  testPathIgnorePatterns: ['/node_modules/', '<rootDir>/coverage'],
+  testPathIgnorePatterns: [
+    '/node_modules/',
+    '<rootDir>/coverage',
+    '<rootDir>/dist'
+  ],
 
   // The regexp pattern or array of patterns that Jest uses to detect test files
   // testRegex: [],

diff --git a/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.Player.js b/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.Player.js
@@ -5,15 +5,13 @@ export class Player {
 
   score = 0;
 
-  toString() {
-    // Given code
-    this.name.toString();
-    return '';
+  constructor(name, score) {
+    this.name = name;
+    this.score = score;
   }
 
-  comparator(bPlayer) {
-    // Given code
-    return 0 * this.score * bPlayer.score;
+  toString() {
+    return `${this.name} ${this.score}`;
   }
 }
 

diff --git a/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.js b/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.js
@@ -16,10 +16,6 @@ export class SortablePlayer extends Player {
     this.score = score;
   }
 
-  toString() {
-    return `${this.name} ${this.score}`;
-  }
-
   comparator(bPlayer) {
     if (this.score > bPlayer.score) {
       return -1;

diff --git a/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.test.js b/src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.test.js
@@ -11,18 +11,16 @@ import TEST_CASES from './ctci_comparator_sorting.testcases.json';
 
 describe('comparatorSorting', () => {
   it('test_player', () => {
-    expect.assertions(2);
+    expect.assertions(1);
 
-    const aPlayer = new Player();
+    const _NAME_ = 'name';
+    const _SCORE_ = 0;
+
+    const aPlayer = new Player(_NAME_, _SCORE_);
     const aPlayerAsString = aPlayer.toString();
-    const aExpected = '';
+    const aExpected = 'name 0';
 
     expect(aExpected).toStrictEqual(aPlayerAsString);
-
-    const bPlayer = new Player();
-    const comparatorAnswerExpected = 0;
-
-    expect(aPlayer.comparator(bPlayer)).toStrictEqual(comparatorAnswerExpected);
   });
 
   it('test_comparator_sorting', () => {