fix: Process variable before the end of scope #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a variable is used in a short php open echo tag, it should be marked as used.
fixes sirbrillig#323 When the last php code is a short php open echo tag using a variable, process the variable before processing the end of scope.
|
Thank you! Sorry it took so long to review. I've been AFK for a month. This is a very elegant fix although I'm not 100% sure I understand how it solves this bug since a token that's a variable shouldn't also be a token that closes a scope, but the tests pass so I'm content. |
|
Thanks for the review @sirbrillig, that was pretty quick to be honest. Hope you had a good break from the keyboard :) To elaborate on how this fixes the issue, the variable isn't a token that would close a scope. It has just ended up as the last non-empty token in the file, making it the end of the top-level scope. |
|
Ahh, that makes sense. Thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #323
When the last php code is a short php open echo tag using a variable,
process the variable before processing the end of scope.