Support nested arrow functions #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
force-pushed
the
support-nested-arrow-functions
branch
from
124cc5f
to
8d6ab7c
Compare
|
The failing tests are just a psalm error (#335) and are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I find the scope opener for an arrow function is by searching backwards for a
fntoken from the place a variable is used if that variable might be within an arrow function. However, if there's another nested arrow function before the actual scope opener we want, this will result in a false positive and report the incorrect scope.In this PR, we add a condition to the algorithm which searches backwards for the
fntoken: if it finds an arrow function scope close token before it finds a scope opener, then we move back to the start of that scope before continuing to search backwards.Fixes #329