Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document sitePassByRefFunctions option #71

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

sirbrillig
Copy link
Owner

Currently this sniff will not report undefined variables which are passed as arguments to certain functions that are designed to assign those variables a value by reference. For example, preg_match('foo', $bar) will not report $bar as undefined.

This PR adds documentation and better tests for the sitePassByRefFunctions option that already existed but was undocumented. That option allows adding custom functions to the list of pass-by-reference functions.

Inspired by #67 (see also #69)

@sirbrillig sirbrillig changed the title Document site pass by ref Document sitePassByRefFunctions option Feb 8, 2019
@sirbrillig sirbrillig merged commit 0c10516 into master Feb 8, 2019
@sirbrillig sirbrillig deleted the document-site-pass-by-ref branch February 8, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant