Add checks for class properties #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
force-pushed
the
fix-anon-class-with-properties
branch
from
fa48318 to
2701848
Compare
Previously they were creating an anonymous class in the global namespace outside a function, but this is an unrealistic usage and probably is being effected by #37. This modifies the fixtures to put the class as a return value of a class method.
sirbrillig
force-pushed
the
fix-anon-class-with-properties
branch
from
2701848 to
063ea67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to now, the sniff was treating class property declarations as regular variable declarations in some cases and property reads in other cases. I think this was causing some odd bugs, like #75.
This PR adds an explicit check for class property declarations (using
public,private,protected,var,static, orpublic static, etc.) and ignores them.Fixes #75