enable saved search selection filtering #100
Conversation
|
wow, super cool! :) thanks.
just to share consider that one of the next likely steps in this component
is to allow the selection of "dashboards" also (instead of saved searches)
this allows one to project on the timeline only selected subsets - in
case of Kibi for example show only the events that are relationally related
to a group of entities currently selected in the dashboard.
this is compatible with what you have here (one would need to simply also
search in dashboard names and make a visual distinction)
thanks again
Adds an input to the kibiSelectPort directive. The value of this input is
used to query saved searches. When the value changes, an
elasticsearch/.kibana/search/_search?size=100 request is sent to the server
to request saved searches containing the input value in either the title or
description.
… The ability to filter saved searches allows users to select saved searches
once the kibana index exceeds 100 saved searches as defined in issue #99
<#99>. The
ability to filter saved searches also allows users to easily find a saved
search as the selection list gets longer.
[image: image]
<https://cloud.githubusercontent.com/assets/373691/21559002/d0ff5438-ce00-11e6-904f-0eed6f136cf9.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#100
Commit Summary
- enable saved search selection filtering
File Changes
- *M* public/kibi_timeline_vis_params.html
<https://github.com/sirensolutions/kibi_timeline_vis/pull/100/files#diff-0>
(2)
- *M* public/lib/directives/kibi_select.html
<https://github.com/sirensolutions/kibi_timeline_vis/pull/100/files#diff-1>
(2)
- *M* public/lib/directives/kibi_select.js
<https://github.com/sirensolutions/kibi_timeline_vis/pull/100/files#diff-2>
(10)
- *M* public/lib/directives/kibi_select_helper.js
<https://github.com/sirensolutions/kibi_timeline_vis/pull/100/files#diff-3>
(22)
Patch Links:
- https://github.com/sirensolutions/kibi_timeline_vis/pull/100.patch
- https://github.com/sirensolutions/kibi_timeline_vis/pull/100.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#100>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEuGyI1r0vP_kRZ7aLJTz-JGNZeS70ujks5rNHM7gaJpZM4LX-UJ>
.
|
|
Can one of the admins verify this patch? |
|
jenkins test it |
|
@nreese please rebase on master as there is 1 test failing (it was already fixed on master) |
nreese
force-pushed
the
filterSavedSearches
branch
from
8484b1c to
efb2e79
Compare
|
@scampi Imagine a kibana instance with 120 saved searches. In the current implementation, the |
|
@nreese I misunderstood what this PR tries to fix, now it's clear, thanks |
| @@ -6,6 +6,8 @@ define(function (require) { | |||
| config, $http, courier, indexPatterns, timefilter, Private, Promise, kbnIndex | |||
| ) { | |||
|
|
|||
| const searchService = Private(require('ui/saved_objects/saved_object_registry')).byLoaderPropertiesName.searches; | |||
There was a problem hiding this comment.
add savedSearches to the argument list above and remove this.
|
|
|
Why is CLAassistant flagging me for not signing a CLA? I signed one a couple of months ago |
|
@nreese we moved to this new CLA tool that is easily integrated with github. Although it is the same agreement as before, could you accept it one more time ? thanks. |
|
jenkins test it |
Adds an input to the
kibiSelectPortdirective. The value of this input is used to query saved searches. When the value changes, anelasticsearch/.kibana/search/_search?size=100request is sent to the server to request saved searches containing the input value in either the title or description.The ability to filter saved searches allows users to select saved searches once the kibana index exceeds 100 saved searches as defined in issue #99. The ability to filter saved searches also allows users to easily find a saved search as the selection list gets longer.
close #99