Use kibiUtils.getValuesAtPath in favor of _.get

[RubieV]

This adds the feature to get arrays from the es result document, by reusing kibiUtils.getValuesAtPath with .split('.'). This feature might be implemented on a higher level of abstraction, to get rid of params.labelFieldSequence statements altogether.

[sindicetech-jenkins]

Can one of the admins verify this patch?

[szydan]

jenkins test it

[RubieV]

Failing: Kibi Timeline Kibi Timeline TimelineHelper pluckLabel should return the label of an event kibana-style
Will update tests to make it pass.

[scampi]

Thanks for the patch. The parameter labelFieldSequence will not be removed because it is used for supporting dots in field names, although it is a controversial feature.

[RubieV]

@scampi I prefer to keep labelFieldSequence, and remove the Kibana's labelField to also make use of labelFieldSequence. It seems that the existence of the fields variable marks the difference between Kibi and Kibana. Is there a helper function for this?

When confirmed, we can move to only use labelFieldSequence uniformly.

Initialisation:

kibi_timeline_vis/public/kibi_timeline_vis_controller.js

Lines 80 to 86 in 220ad17

	labelFieldSequence: fields[i].byName[group.labelField].path,
	startFieldSequence: fields[i].byName[group.startField].path,
	endFieldSequence: group.endField && fields[i].byName[group.endField].path || [],
	//kibana params
	labelField: group.labelField,
	startField: group.startField,
	endField: group.endField,

Usage:

kibi_timeline_vis/public/lib/helpers/timeline_helper.js

Lines 28 to 32 in 4545908

	if (params.labelFieldSequence) { // in kibi, we have the path property of a field
	field = kibiUtils.getValuesAtPath(hit._source, params.labelFieldSequence);
	} else {
	field = _.get(hit._source, params.labelField);
	}

[RubieV]

781b573 fixes case where there is not split on dot, forces array creation.

[scampi]

This feature might be implemented on a higher level of abstraction, to get rid of params.labelFieldSequence statements altogether.

You meant Kibana ? If so, sorry I misread this. In kibana the support for objects in arrays has been improved and so it shouldn't be needed to use the kibiUtils version. However, in Kibi we support dots in fieldnames which kibana will not. If we choose to still support this, then those statements are still needed.

[scampi]

jenkins test it

[RubieV]

Sorry for the late commits, I've updated the build artifact and added test coverage for Kibana. I had issues running the tests, so please let Jenkins do a check.

[scampi]

jenkins test it

[scampi]

Please remove the zip file from the PR

[scampi]

I don't understand why this is needed. The split always returns an array.

[CLAassistant]

All committers have signed the CLA.

[szydan]

jenkins test it

[scampi]

@RubieV please accept the PR RubieV#1

[RubieV]

Accepted

[szydan]

jenkins test it

[RubieV]

Sorry to bother, any updates on the status?

[scampi]

@RubieV finishing this in #123 thanks