Update & simplify goverter #17
Conversation
Field settings may only be configured on struct or struct pointers. See https://goverter.jmattheis.de/guide/configure-nested With the newest goverter versios this is an error.
Goverter has features to prevent compile errors when generating the converter into the same package. This commit basically follows the example listed in the guide. See https://goverter.jmattheis.de/guide/output-same-package
The output changed because the logic when goverter creates now methods was changed. The implementation should still behave the same.
|
Wow! Thank you so much! I was looking for a code generator to copy my database domain objects into the game domain and |
| csFleet.MapObject = ExtendFleetMapObject((*source)) | ||
| csFleet.FleetOrders = ExtendFleetFleetOrders((*source)) | ||
| csFleet.PlanetNum = (*source).PlanetNum | ||
| csFleet.BaseName = (*source).BaseName | ||
| csFleet.Cargo = c.dbFleetToCsCargo((*source)) | ||
| csFleet.Fuel = (*source).Fuel | ||
| csFleet.Age = (*source).Age | ||
| csFleet.Tokens = ShipTokensToGameShipTokens((*source).Tokens) | ||
| csFleet.Heading = ExtendFleetHeading((*source)) | ||
| csFleet.WarpSpeed = (*source).WarpSpeed | ||
| csFleet.PreviousPosition = ExtendFleetPreviousPosition((*source)) | ||
| csFleet.OrbitingPlanetNum = (*source).OrbitingPlanetNum | ||
| csFleet.Starbase = (*source).Starbase | ||
| csFleet.Spec = FleetSpecToGameFleetSpec((*source).Spec) |
There was a problem hiding this comment.
I have a question on this generated code. Won't this create a copy of source for each variable assignment?
I think this pointer dereferencing makes a copy of the struct each time. I'm not sure if the go compiler optimizes that sort of thing away.
csFleet.PlanetNum = (*source).PlanetNum
csFleet.BaseName = (*source).BaseName
csFleet.Fuel = (*source).Fuel
csFleet.Age = (*source).AgeIn the previous iteration, the pointer was only dereferenced once when calling
c.dbFleetToCsFleet((*source))There was a problem hiding this comment.
Dereferencing does not copy source, dereferencing only gets the underlying value. The code above is actually what happens in the background when you access fields on a struct pointer in go. E.g.
type S struct{ Name string }
func main() {
var s *S = nil
_ = s.Name
_ = *s
}
Both expressions s.Name and *s dereference s and they also both throw the same nil panic.
There was a problem hiding this comment.
Oh nice, I didn’t realize that but it makes sense. Thanks!
I've found your project while looking for projects using goverter. It's great
to see how it's used (:. I've upgraded it to the newest version and simplified
some stuff. See commit messages for explanations.
The last commit is a showcase how some custom code could be converted, I think
both solutions are valid, so I haven't changed this for every occurrence.
I've also created the feature request for regex
goverter:mapinjmattheis/goverter#122 because this would simplify a
lot of
goverter:mapcalls here.Goverter can be execute with
go generate ./db