Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layout] TypeError: Cannot read property 'slice' of undefined #926

Closed
raghav0622 opened this issue Aug 9, 2020 · 9 comments
Closed

[Layout] TypeError: Cannot read property 'slice' of undefined #926

raghav0622 opened this issue Aug 9, 2020 · 9 comments
Labels
Material UI (v5) Support @mui/material v5

Comments

@raghav0622
Copy link

When setting up layout in scheme.configure**(...) above mentione error is shown
code: -

Screenshot 2020-08-09 202721
Screenshot 2020-08-09 202802
Screenshot 2020-08-09 202844

@siriwatknp
Copy link
Owner

Did you follow this tutorial? https://mui-treasury.com/layout/tutorials/dashboard-layout/

If you can provide codesandbox or github repo that I can reproduce, I can help.

Finally, I haven't test with styled from @material-ui/styles before. will try this weekend.

@raghav0622
Copy link
Author

Did you follow this tutorial? https://mui-treasury.com/layout/tutorials/dashboard-layout/

If you can provide codesandbox or github repo that I can reproduce, I can help.

Finally, I haven't test with styled from @material-ui/styles before. will try this weekend.

Yes i did follow the tutorial, all i am using is Nextjs and rest of the code is here!

@raghav0622
Copy link
Author

Did you follow this tutorial? https://mui-treasury.com/layout/tutorials/dashboard-layout/

If you can provide codesandbox or github repo that I can reproduce, I can help.

Finally, I haven't test with styled from @material-ui/styles before. will try this weekend.

@siriwatknp
please make this library compatible with default exported styled from @material-ui/core as styled-components RFC is a long time wait before it is finally adopted (heated debate is going on perf vs dev-exp etc in RFC in @material-ui/core), till then make it compatible with styled as i wouldn't want to increase complexity of project by using tailwindcss, material-ui and styled-components all together with nextjs. (opens room for more bugs and typerrors).
Thanks for this awesome project though

@neyasov
Copy link

neyasov commented Aug 13, 2020

@siriwatknp Bug related to alpha versions of material-ui v5.0.0-alpha.6
export "keys" renamed to "breakpointKeys"
mui/material-ui#21759

@siriwatknp siriwatknp added the bug label Aug 15, 2020
@siriwatknp
Copy link
Owner

siriwatknp commented Aug 15, 2020

@raghav0622 @neyasov Should I make a release as @mui-treasury/layout v5.0.0 for this fix to follow material-ui/core version? What do you guys think?

@neyasov
Copy link

neyasov commented Aug 15, 2020

@siriwatknp I think we need alpha or beta release, because there may still be breaking changes to @material-ui v5

@raghav0622
Copy link
Author

@raghav0622 @neyasov Should I make a release as @mui-treasury/layout v5.0.0 for this fix to follow material-ui/core version? What do you guys think?

thats the best way, this way this repo will match to version of material-ui and also consider using default styled exported from @material-ui/core as whaterver styled-components library material-ui adopts, it will export it styled from its core...

@agemxc
Copy link

agemxc commented Sep 17, 2020

With lerna publish you can make an alpha version,like v5.0.0-alpha.01,
when we have assurance that material ui is stable and react 17 its bug free you can create the 5.0.0 Version
What you think?
For those who trying to use the version v5.0.0 of material-ui only works
"@material-ui/core": "5.0.0-alpha.2" after this version they made a renaming .

@siriwatknp siriwatknp added Material UI (v5) Support @mui/material v5 and removed bug labels Apr 15, 2021
@siriwatknp
Copy link
Owner

Layout v5 has been released! https://www.npmjs.com/package/@mui-treasury/layout/v/5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Material UI (v5) Support @mui/material v5
Projects
None yet
Development

No branches or pull requests

4 participants