Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Fix custom breakpoint in CSS Media Queries #21759

Merged
merged 1 commit into from
Jul 12, 2020
Merged

[theme] Fix custom breakpoint in CSS Media Queries #21759

merged 1 commit into from
Jul 12, 2020

Conversation

nkrivous
Copy link
Contributor

@nkrivous nkrivous commented Jul 11, 2020 •
edited by oliviertassinari
Loading

Fixed CSS Media Queries for custom breakpoints.

Resolves #21745

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 3982f50

@joshwooding joshwooding added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material labels Jul 11, 2020
@joshwooding joshwooding changed the title CSS Media Queries don't work with Custom breakpoints [core] Fix custom breakpoint support in CSS Media Queries Jul 11, 2020
joshwooding
joshwooding suggested changes Jul 11, 2020
View reviewed changes
Copy link
Member

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one minor thing.

packages/material-ui/src/styles/createBreakpoints.js Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title [core] Fix custom breakpoint support in CSS Media Queries [theme] Fix custom breakpoint in CSS Media Queries Jul 11, 2020
@oliviertassinari oliviertassinari merged commit d38f7e8 into mui:next Jul 12, 2020
@oliviertassinari
Copy link
Member

@nkrivous It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jul 15, 2020
@nkrivous @eps1lon
[theme] Fix custom breakpoint in CSS Media Queries (mui#21759)
37e3389
@neyasov neyasov mentioned this pull request Aug 13, 2020
Closed
@stefaluc stefaluc mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Media Queries don't work with Custom breakpoints
4 participants
@nkrivous @mui-pr-bot @oliviertassinari @joshwooding