Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFML migration update #1727

Merged
merged 4 commits into from
Dec 18, 2024
Merged

SFML migration update #1727

merged 4 commits into from
Dec 18, 2024

Conversation

jopadan
Copy link
Contributor

@jopadan jopadan commented Sep 23, 2024

SFML/migration.md updated with #if (SFML_VERSION_MAJOR > 2)

@sirjuddington
Copy link
Owner

This one will probably need some SFML version checks to keep support for 2.x, at least for a while

@jopadan jopadan force-pushed the master branch 3 times, most recently from aa90275 to 783a36e Compare October 24, 2024 13:08
@Blzut3
Copy link
Collaborator

Blzut3 commented Nov 19, 2024

The changes to .gitingore here indicate that you're using CMake wrong. You should set your build directory to an empty directory. Commonly people just mkdir build inside their clone and use that, but it can be entirely out of tree too. This is important since CMake doesn't provide a way to cleanup its generated files besides "delete the build directory."

@sirjuddington
Copy link
Owner

@jopadan sorry I haven't got to this one yet, could you remove the changes to .gitignore (see @Blzut3's comment) and I'll merge it in

@sirjuddington sirjuddington merged commit 84a3c9b into sirjuddington:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants