Support wxWidgets 3.3 and dark theme in Windows #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done in the 3.3.0 branch, will need to be done for this too so we don't have any wx references in thirdparty (via #including Main.h)
Added the option to download/build wx via cmake using FetchContent instead of using the system wx lib (windows-only currently), so we can build with wxWidgets 3.3.0 if needed. With wx 3.3 we can now enable the 'experimental' dark theme support in Windows. Added an option to select the theme (or go with the system preference, which is the default) and made some tweaks to support the dark theme. There are a few minor issues but it works well enough for the most part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to download/build wx via cmake using FetchContent instead of using the system wx lib (windows-only currently), so we can build with wxWidgets 3.3.0 if needed.
With wx 3.3 we can now enable the 'experimental' dark theme support in Windows. Added an option to select the theme (or go with the system preference, which is the default) and made some tweaks to support the dark theme. There are a few minor issues but it works well enough for the most part.