Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Tables #5

Closed
wants to merge 54 commits into from
Closed

HTML API: Tables #5

wants to merge 54 commits into from

Commits on Jun 28, 2024

  1. Tests: Use assertSame() in WP_Interactivity_API tests.

    This ensures that not only the return values match the expected results, but also that their type is the same.
    
    Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
    
    Follow-up to [57563], [57649], [57822], [57826], [57835], [58159], [58327].
    
    See #61530.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58594 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    80bd30e View commit details
    Browse the repository at this point in the history
  2. Build/Test Tools: Introduce two additional reusable PHPUnit workflows.

    The changes associated with #61213 aim to update all branches potentially receiving security updates to use the same workflow files for easier maintenance as much as possible. However, there are times when the logic found in GitHub Action workflow files changes pretty drastically.
    
    For PHPUnit testing, there are 2 instances where this occurred: the 5.2 and 5.9 branches. This changeset introduces 2 new reusable PHPUnit workflow files for use the 4.1-5.1 and 5.2-5.9 branches.
    
    Including these workflows in `trunk` makes it more clear which version of the workflow file is used by these old branches, and allows Dependabot to open PRs for updating 3rd-party actions within these workflows.
    
    Props jorbin.
    See #61213.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58595 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b9ecee3 View commit details
    Browse the repository at this point in the history
  3. Build/Test Tools: Allow older branches to use Coding Standards workflow.

    This updates the reusable coding standards GitHub Actions workflow to support the old way of running PHPCS commands when the `old-branches` input flag is set to `true`. This allows the 5.1-5.4 branches to use the same workflow as all other 5.5+ branches.
    
    See #61213.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58596 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d3ac93a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Date/Time: Replace abbreviations for minutes in human_time_diff().

    This ensures that relative times are formatted the same way in both JS and PHP.
    
    Follow-up to [1976], [2124], [4658], [41018], [56496].
    
    Props wildworks.
    Fixes #61535.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58600 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    57910f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Date/Time: Correct singular form for minutes in human_time_diff().

    Follow-up to [58600].
    
    Props wildworks.
    See #61535.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58601 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    6645c75 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. REST API: Correct image cropping tools in the block editor.

    As of [58457], the width and height cropping values are cast to an integer before the comparison to see if the target width and height differ from the original width and height.
    
    Since they are now integers, it exposes a bug where the `&&` of the `if` conditional meant that if you were only cropping in one dimension, the check wouldn't pass, and cropping would not occur.
    
    In the block editor, the cropping tools are aspect ratio based, so one of the dimensions will always match that of the source image. Therefore, now that the values are cast as integers, the condition that allows a cropping to occur needs to be updated. If either width or height is different from the source image, then a crop should be allowed.
    
    Follow-up to [50124], [58457].
    
    Props andrewserong, jrf, kevin940726.
    Fixes #61514. See #59782.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58612 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    80409a2 View commit details
    Browse the repository at this point in the history
  2. HTML API: Optimize low-level parsing details in Tag Processor.

    Introduces a number of micro-level optimizations in the Tag Processor to
    improve token-scanning performance. Should contain no functional changes.
    
    Based on benchmarking against a list of the 100 most-visited websites,
    these changes result in an average improvement in performance of the Tag
    Processor for scanning tags from between 3.5% and 7.5%.
    
    Developed in WordPress#6890
    Discussed in https://core.trac.wordpress.org/ticket/61545
    
    Follow-up to [55203].
    
    See #61545.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58613 602fd350-edb4-49c9-b593-d223f7449a82
    dmsnell committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cf064ef View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Block Hooks: Allow child insertion into Template Part block.

    The Block Hooks mechanism was previously extended to allow insertion of a block as a Navigation block's first or last child. This was implemented by storing the `ignoredHookedBlocks` array in the corresponding `wp_navigation` post's post meta (instead of a metadata attribute on the anchor block).
    
    This changeset extends that mechanism to Template Part blocks, by storing said metadata in the corresponding `wp_template_part` post's post meta, thus allowing extenders to use Block Hooks to insert a block as a Template Part block's first or last child, respectively.
    
    Props tomjcafferkey, bernhard-reiter.
    Fixes #60854.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58614 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fdebb53 View commit details
    Browse the repository at this point in the history
  2. Block Hooks: Fix a number of multi-line comment openers.

    Add the missing second asterisk to a number of multi-line comment openers, and remove a superfluous second asterisk from two others.
    
    Follow-up to [58614].
    Props mukesh27.
    See #60854.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58615 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a2bb45d View commit details
    Browse the repository at this point in the history
  3. Plugins: Remove extra paragraph from plugin row dependency notice.

    In `WP_Plugins_List_Table::add_dependencies_to_dependent_plugin_row()`, a `sprintf()` call previously wrapped the `%2$s` placeholder in paragraph tags.
    
    [57769] changed the placeholder's value to use `wp_get_admin_notice()`, which returns a paragraph-wrapped notice by default. As a result, the previous paragraph tags produced an extra, empty paragraph.
    
    This removes the paragraph tags around the `%2$s` placeholder.
    
    Follow-up to [57545], [57714], [57769].
    
    Props mukesh27.
    Fixes #61546.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58616 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d77bb08 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    486c9a2 View commit details
    Browse the repository at this point in the history
  5. Help/About: Add images to the About page.

    The images have been uploaded to the w.org CDN and added into the About page. Additionally, the link to the release page has been fixed, and an extra translator note about the escaped percent sign has been added.
    
    Follow-up to [58568].
    
    Props ryelle, joen.
    See #61320.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58618 602fd350-edb4-49c9-b593-d223f7449a82
    ryelle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6af6395 View commit details
    Browse the repository at this point in the history
  6. Login and Registration: Remove redundant escaping in wp-login.php.

    * `$user_login` in the `login` action is already escaped on output.
    * `$user_login` and `$user_email` in the `register` action are already unslashed a few lines above.
    
    Follow-up to [3120], [4339], [8454], [11104], [23416], [23554], [23594], [46640].
    
    Props johnjamesjacoby, rajinsharwar, narenin.
    Fixes #55335.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58623 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    67aa1d9 View commit details
    Browse the repository at this point in the history
  7. Twenty Nineteen: Adds center alignment to Archives and Categories Lis…

    …t blocks.
    
    When selecting center alignment for Archives or Categories List blocks the alignment was not matching. It is worth noting this fixes for these blocks but another ticket could be made to fix for titles.
    
    Props pranitdugad, sabernhardt.
    Fixes #47044.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58627 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    24646a4 View commit details
    Browse the repository at this point in the history
  8. Twenty Twenty-One: Resolves bug on primary navigation.

    The primary navigation was stuck in a vertical list when resize. This resolves that with positioning.
    
    Props nek285, mukesh27.
    Fixes #52663.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58629 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f1a3d20 View commit details
    Browse the repository at this point in the history
  9. Twenty Nineteen: Fixes font size and citation display for Pullquote b…

    …lock.
    
    The pullquote block text decoration was not the same front and within the editor. This resolves that and resets.
    
    Props pitamdey, viralsampat, sabernhardt.
    Fixes #61507.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58630 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d510058 View commit details
    Browse the repository at this point in the history
  10. HTML API: Add missing insertion mode constants.

    As the HTML Processor starts to support other insertion modes outside of
    "IN BODY" it needs to be aware of those other modes. This patch
    introduces the missing insertion modes in preparation for adding that
    support.
    
    Extracted as necessary prep work to the following more complete change:
    WordPress#6020
    
    Props jonsurrell.
    See #61549.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58631 602fd350-edb4-49c9-b593-d223f7449a82
    dmsnell committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ea3327a View commit details
    Browse the repository at this point in the history
  11. Themes: add "description" key to i18n schema

    Add "description" key to the theme.json i18n schema.
    
    Follows r56041.
    Fixes #61543.
    Props ramonopoly, oandregal.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58632 602fd350-edb4-49c9-b593-d223f7449a82
    noisysocks committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2930212 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Twenty Ten: Fixes table and calendar block font size issues.

    The table and calendar block font sizes were not the same on front and in editor. This resolves in using relative line-height.
    
    Props iamfarhan09, bijit027, sabernhardt.
    Fixes #58362.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58633 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    de74333 View commit details
    Browse the repository at this point in the history
  2. Twenty Seventeen and Twenty Ten: Fixes gallery captions being at the …

    …bottom of images.
    
    The margin specified in this theme caused issues when the gallery was placed in another block. This fix covers both themes as the selector is used within both.
    
    Props pevogam, sabernhardt.
    Fixes #58362.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58634 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a285228 View commit details
    Browse the repository at this point in the history
  3. Twenty Sixteen: Fixes editor styles for table and calendar blocks and…

    … captions.
    
    The table and calendar block font sizes were not as expected on front end within editor. This includes changes for header cells (th), removes redundant font size rules, corrects font-weight and updates figcaption selector along with editing text alignment and adding RTL font selection.
    
    Props nidhidhandhukiya, sabernhardt, sheulyshila, iamfarhan09, bijit027, jannathsyeda, pooja1210, shailu25, hmbashar.
    Fixes #58355.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58635 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6d40ef3 View commit details
    Browse the repository at this point in the history
  4. Build/Test Tools: Rename current reusable PHPUnit workflow.

    This adds a ` -v3` suffix to the current reusable PHPUnit workflow name. This avoids having to update older branches in the future when the workflow’s logic drastically changes and a `v4` is needed.
    
    See #61213.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58645 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4454f4a View commit details
    Browse the repository at this point in the history
  5. Users: Pass the previous state of the user as context to the `wp_set_…

    …password` hook.
    
    Follow-up to [55056], [55250].
    
    Props dd32.
    Fixes #61541.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58653 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5466b9c View commit details
    Browse the repository at this point in the history
  6. Build/Test Tools: Fix workflow names in test old branches workflow.

    After the changes in [58165] and [58645] and all associated backports, the workflow that dispatches regular testing in older branches needed to be updated.
    - The `test-npm.yml` workflow no longer exists.
    - The `test-build-processes.yml` has taken the place of `test-npm.yml` in all branches.
    
    Also, the workflow will now run whenever an old version of the reusable PHPUnit workflow is updated (v1 or v2). This is to ensure the changes don’t cause any compatibility problems in older branches.
    
    See #61213.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58654 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e65f0f2 View commit details
    Browse the repository at this point in the history
  7. HTML API: Implement the _reset insertion mode appropriately_ algorithm.

    In order to add support for the SELECT and TABLE tags in the HTML Processor, it
    needs to implement the HTML algorithm named "reset the insertion mode
    appropriately".
    
    This patch implements that algorithm to unblock the additional tag support. The
    algorithm resets the parsing mode after specific state changes in complicated
    situations where alternative rules are in effect (such as rules governing how
    the parser handles tags found within a TABLE element).
    
    Developed in WordPress#6020
    Discussed in https://core.trac.wordpress.org/ticket/61549
    
    Props dmsnell, jonsurrell.
    Fixes #61549.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58656 602fd350-edb4-49c9-b593-d223f7449a82
    dmsnell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    28930fc View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Help/About: Update performance improvements string.

    Updates the performance improvements string with the finalized percentage improvement in the editor and to improve styling and language consistency.
    
    Props ryelle, annezazu, peterwilsoncc.
    Fixes #61320.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58671 602fd350-edb4-49c9-b593-d223f7449a82
    peterwilsoncc committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    80b7747 View commit details
    Browse the repository at this point in the history
  2. Docs: Update AJAX in Plugins HelpHub link to avoid unnecessary redire…

    …ction.
    
    Follow-up to [17045], [20713], [41065], [45674], [55412], [57854], [58131], [58132].
    
    Props shailu25.
    See #60732, #60699.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@58672 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    922949f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b867b58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9245930 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    267a27b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b0475fb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1944b66 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8d4b4df View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1404119 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dc0bbb9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9d99844 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    352a75f View commit details
    Browse the repository at this point in the history
  13. Work on table support

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ceae9d4 View commit details
    Browse the repository at this point in the history
  14. table processing

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    922948a View commit details
    Browse the repository at this point in the history
  15. Disable FRAME / HEAD

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    89184de View commit details
    Browse the repository at this point in the history
  16. In table body rules

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a68527a View commit details
    Browse the repository at this point in the history
  17. prep step_in_row

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    afb35bc View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a596326 View commit details
    Browse the repository at this point in the history
  19. phpcbf and implement in row

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    376be8d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    4d6f1e5 View commit details
    Browse the repository at this point in the history
  21. Add step_in_cell method

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    963390e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b72f6d9 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    8a41658 View commit details
    Browse the repository at this point in the history
  24. Update since tags

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    164d81f View commit details
    Browse the repository at this point in the history
  25. Add close_cell method

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    57f5d6d View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c078160 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    41320ac View commit details
    Browse the repository at this point in the history
  28. Implement in_table_scope

    sirreal committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    33ffc83 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    759ca17 View commit details
    Browse the repository at this point in the history