Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support colors on Windows 10 #820

Closed
andrewsav-bt opened this issue Sep 13, 2018 · 8 comments · Fixed by #822
Closed

Support colors on Windows 10 #820

andrewsav-bt opened this issue Sep 13, 2018 · 8 comments · Fixed by #822

Comments

@andrewsav-bt
Copy link

I'm confused with the state of this issue. There are a couple of closed issue here and here.

They discuss resolving the issue then reversing the change, and then fixing it again?

Anyway it does not seem to be working for me:
2018-09-13_15-51-37

Program:

package main
import (
	log "github.com/sirupsen/logrus"
)
func main() {
	log.SetFormatter(&log.TextFormatter{})
	log.Errorf("Hello World!")
}

run with:

go run main.go

result:

�[31mERRO�[0m[0000] Hello World!

What is the current status of this?

@dgsb
Copy link
Collaborator

dgsb commented Sep 16, 2018

Hello @andrewsav-datacom , we do have a pending pr #741 for this issue, but I have no way to test if it works as intended. Can you checj after I've merged that it works as intended ?

@AndrewSav
Copy link

@dgsb I can try but it also can take a little while. Thanks.

@dgsb dgsb closed this as completed in #822 Sep 16, 2018
@dgsb dgsb reopened this Sep 16, 2018
@dgsb
Copy link
Collaborator

dgsb commented Sep 16, 2018

@andrewsav-datacom the pr has been merged on master, you can check if it works appropriatly for you. If it does you can then close this issue. Thanks.

@AndrewSav
Copy link

AndrewSav commented Sep 16, 2018

@dgsb for the test case above the changes has worked on windows 10. I'll try to test on windows 7 as well and will let you know.

@AndrewSav
Copy link

AndrewSav commented Sep 16, 2018

@dgsb It does not work on Windows 7 though. Sorry. Let me know if you would like me to open an issue for that.

@a-h
Copy link

a-h commented Oct 11, 2018

I also get control sequences rendered to the console when using PowerShell on Windows Server 2012.

screen shot 2018-10-11 at 09 46 31

I get the same issue when using cmd.exe too.

@AndrewSav
Copy link

@a-h I have a suspicion that if you want this fixed you will be better off opening a new issue, or commenting on an issue that is not closed...

@dgsb
Copy link
Collaborator

dgsb commented Oct 11, 2018

indeed, please open new issues otherwise it gets very hard to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants