Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log output for windows #376

Closed
anjannath opened this issue Aug 5, 2019 · 0 comments · Fixed by #377
Closed

Fix log output for windows #376

anjannath opened this issue Aug 5, 2019 · 0 comments · Fixed by #377

Comments

@anjannath
Copy link
Member 

PS > .\crc.exe setup
^[[36mINFO^[[0m Caching oc binary
^[[36mINFO^[[0m Unpacking bundle from the CRC binary
^[[33mWARN^[[0m CRC bundle is not embedded in the binary, see 'crc help' for more details.
^[[36mINFO^[[0m Check Windows 10 release

This is an issue with logrus, see sirupsen/logrus#379 and sirupsen/logrus#820, but as a workaround as mentioned in sirupsen/logrus#379 (comment) we can use the go-colorable package's writer.
anjannath added a commit to anjannath/crc that referenced this issue Aug 5, 2019
@anjannath
Issue crc-org#376 Fix colored log output for windows
042f30e 
This issue comes from logrus, see sirupsen/logrus#379
but as a workaround as mentioned in the above issue we can use the `go-colorable`
package's writer.
@anjannath anjannath mentioned this issue Aug 5, 2019
Merged
anjannath added a commit to anjannath/crc that referenced this issue Aug 5, 2019
@anjannath
Issue crc-org#376 Fix colored log output for windows
94935c1 
This issue comes from logrus, see sirupsen/logrus#379
but as a workaround as mentioned in the above issue we can use the `go-colorable`
package's writer.
gbraad pushed a commit that referenced this issue Aug 5, 2019
@anjannath @gbraad
Issue #376 Fix colored log output for windows
fbc4a7a 
This issue comes from logrus, see sirupsen/logrus#379
but as a workaround as mentioned in the above issue we can use the `go-colorable`
package's writer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #376 Fix colored log output for windows anjannath/crc
1 participant
@anjannath