feat: copy Caller to new entry if reportCaller is not set #1251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy
Caller
to new entry if ReportCaller is not set whenlog
.There are some scenarios where users want to pass the caller by themself, for example, many libraries accept a logger interface and use it to output internal log(such as SQL exec log for
Gorm
), many users wrap logrus to the needed interface, but the caller got by logrus is inaccuracy in this case, and need to get the caller and pass it into Entry, just throwing caller away will break wrapped loggers for these libraries.Passing caller in
Entry
works util #1229 importedDup
to fix race condition issue.