Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: wrong indexing in branch detecting #12

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

BeastyBlacksmith
Copy link
Contributor

I supposed your intention was to allow multiple spaces between package and version. Otherwise the version_pos2 can be replaced by version_pos.

@johnnychen94
Copy link
Contributor

johnnychen94 commented Aug 25, 2019

Thanks for pointing out the bug. Yes as you may notice, this script is not fully tested.

As a replacement to this script, I think jlpkg is well maintained and works better than this one.

jlpkg --project=@ add $(cat requirements.txt) from fredrikekre/jlpkg#4

@mykelk
Copy link
Member

mykelk commented Aug 25, 2019

Thanks! Shall I merge this PR in for now, and someone can add the jlpkg functionality in a later PR?

@johnnychen94
Copy link
Contributor

Of course, you can merge it as you wish.

@mykelk mykelk merged commit ccd542f into sisl:master Aug 26, 2019
@BeastyBlacksmith BeastyBlacksmith deleted the BeastyBlacksmith-bugfix branch August 26, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants