-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
really drop python<=3.7 support #399
Conversation
Filter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Sorry but too many changes in so many files to be merged in the master branch. I could agree for a merge in the develop branch for a limited set of cases (set, super, ...). Thank you |
All those changes has been generated automatically by |
I understood that, but in development, not in master branch. I saw that pyupgrade doesn't have so many exception options, anyway i will try it during development. Dropping Python 3.7 doesn't mean necessarily that all the codebase is Py38+. In this case the compatibility is dropped mainly by the usage of protocols defined in the base package elementpath. Thank you |
OK I understand. |
Tested on develop. Two things:
|
Also found a bug applying to a module in elementpath. A for-yield is replaced with a diff --git a/elementpath/xpath_context.py b/elementpath/xpath_context.py
index 3b16ee9..483bb85 100644
--- a/elementpath/xpath_context.py
+++ b/elementpath/xpath_context.py
@@ -386,8 +386,7 @@ class XPathContext:
status = self.item, self.axis
self.axis = 'attribute'
- for self.item in self.item.attributes:
- yield self.item
+ yield from self.item.attributes
self.item, self.axis = status |
Just open the ticket in |
Filter all code over
pyupgrade --py38-plus
.